Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create documentation for symfony/symfony#10600 #3745

Closed
romainneutron opened this issue Apr 1, 2014 · 0 comments
Closed

Create documentation for symfony/symfony#10600 #3745

romainneutron opened this issue Apr 1, 2014 · 0 comments

Comments

@romainneutron
Copy link
Contributor

This is a self reminder for creating a doc PR for symfony/symfony#10600.
I'll take care of it in the nexrt few days

fabpot added a commit to symfony/symfony that referenced this issue Apr 1, 2014
…service by keeping a reference to the old one (romainneutron)

This PR was merged into the 2.5-dev branch.

Discussion
----------

[DependencyInjection] added a simple way to replace a service by keeping a reference to the old one

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #5920
| License       | MIT
| Doc PR | symfony/symfony-docs#3745

This PR replaces #9003. Here's the todo list:
 - [x] add a cookbook entry for this new feature
 - [x] add support in all loaders/dumpers
 - [x] add unit tests
 - [x] see if there are use cases in Symfony that would benefit from this new feature
 - [x] find the best name for this feature

I've implemented YAML and XML Loader / Dumper.
From what I see, PhpDumper, PhpLoader, IniLoader, GraphvizDumper do not require an update, am I wrong?

Commits
-------

140f807 [DependencyInjection] Update dumpers and loaders, add unit tests
1eb1f4d [DependencyInjection] added a simple way to replace a service by keeping a reference to the old one
weaverryan added a commit that referenced this issue May 29, 2014
…ecoration (romainneutron)

This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes #3753).

Discussion
----------

[DependencyInjection] Add documentation about service decoration

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | yes (symfony/symfony#10600)
| Applies to    | 2.5+
| Fixed tickets | #3745

Commits
-------

578d2e2 [DependencyInjection] Add documentation about service decoration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants