Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The contributor guide should be updated to send features to 2.7 #4508

Closed
stof opened this issue Nov 21, 2014 · 1 comment
Closed

The contributor guide should be updated to send features to 2.7 #4508

stof opened this issue Nov 21, 2014 · 1 comment
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.

Comments

@stof
Copy link
Member

stof commented Nov 21, 2014

Any new backward-compatible feature should be submitted to the 2.7 branch (which is the default branch now), not to the master branch (which is for 3.0).
But because of the documentation saying to send features to master (or at least I suppose it is because they read the doc), many recent PRs have been submitted to master rather than the default branch 2.7.

IMO, we should update the contributor guide to take into account the fact that 2.7 and 3.0 are being developed in parallel
@wouterj
Copy link
Member

wouterj commented Nov 22, 2014

I agree

@wouterj wouterj added actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Nov 22, 2014
@xabbuh xabbuh mentioned this issue Nov 23, 2014
Merged
@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Nov 26, 2014
weaverryan added a commit that referenced this issue Dec 17, 2014
@weaverryan
bug #4513 [Contributing] update contribution guide for 2.7/3.0 (xabbuh)
0de8286 
This PR was merged into the 2.3 branch.

Discussion
----------

[Contributing] update contribution guide for 2.7/3.0

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4508

Commits
-------

87582a4 update contribution guide for 2.7/3.0
@xabbuh xabbuh closed this as completed Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stof @wouterj @xabbuh