Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contributing] update contribution guide for 2.7/3.0 #4513

Merged
merged 1 commit into from
Dec 17, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 23, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #4508

@wouterj
Copy link
Member

wouterj commented Nov 23, 2014

Like it 👍

@stof
Copy link
Member

stof commented Dec 6, 2014

👍

@javiereguiluz
Copy link
Member

Probably I'm very late to this discussion, but here it is my comment.

I like what @xabbuh has done and everything is correct. But what do you think about transforming that long paragraph into a more actionable list-based format. Something like this:

Before working on a patch, you must determine on which branch you need to work:

* ``2.3``, if you are fixing a bug for an existing feature;
* ``2.7``, if you are adding a new feature which is backward compatible;
* ``master``, if you are adding a new and backward incompatible feature.

@xabbuh
Copy link
Member Author

xabbuh commented Dec 6, 2014

@javiereguiluz NIce suggestion. What do the others think?

@wouterj
Copy link
Member

wouterj commented Dec 6, 2014

@javiereguiluz it's never too late :)

I think it's a great suggestion which would make things a lot easier to understand.

@xabbuh
Copy link
Member Author

xabbuh commented Dec 6, 2014

Updated the pull request.

@xabbuh
Copy link
Member Author

xabbuh commented Dec 15, 2014

Anything else you see that should be changed?

@weaverryan
Copy link
Member

This reads super well - great work guys :)

@weaverryan weaverryan merged commit 87582a4 into symfony:2.3 Dec 17, 2014
weaverryan added a commit that referenced this pull request Dec 17, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

[Contributing] update contribution guide for 2.7/3.0

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4508

Commits
-------

87582a4 update contribution guide for 2.7/3.0
@xabbuh xabbuh deleted the issue-4508 branch December 17, 2014 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants