Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using methods inherited from SplObjectStorage in the Crawler is deprecated #5783

Closed
xabbuh opened this issue Oct 12, 2015 · 0 comments
Closed

Using methods inherited from SplObjectStorage in the Crawler is deprecated #5783

xabbuh opened this issue Oct 12, 2015 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. DomCrawler good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Milestone
2.8

Comments

@xabbuh
Copy link
Member

xabbuh commented Oct 12, 2015

Basically, I only found the components docs mentioning the SplObjectStorage class in its usage section where the link could simply be removed. Though we should check nonetheless if there are other references to the SplObjectStorage class.

The corresponding change in the code repository can be found in symfony/symfony#15907.
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. DomCrawler labels Oct 12, 2015
@xabbuh xabbuh added this to the 2.8 milestone Oct 12, 2015
BenjaminPaap added a commit to BenjaminPaap/symfony-docs that referenced this issue Oct 16, 2015
@BenjaminPaap
Fixes symfony#5783
35037ac
BenjaminPaap added a commit to BenjaminPaap/symfony-docs that referenced this issue Oct 17, 2015
@BenjaminPaap
Fix for symfony#5783
3ff3dd3 
I can confirm, that this is the only place where the `SplStorageObject`
and its methods are referenced.
@BenjaminPaap BenjaminPaap mentioned this issue Oct 17, 2015
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Oct 18, 2015
xabbuh pushed a commit that referenced this issue Oct 19, 2015
@BenjaminPaap @xabbuh
Fix for #5783
065d28c 
I can confirm, that this is the only place where the `SplStorageObject`
and its methods are referenced.
xabbuh added a commit that referenced this issue Oct 19, 2015
@xabbuh
minor #5796 Fix for #5783 (BenjaminPaap)
71469ff 
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5796).

Discussion
----------

Fix for #5783

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.8
| Fixed tickets | #5783

I can confirm, that this is the only place where the `SplStorageObject` and its methods which were marked as deprecated in symfony/symfony#15907 are referenced.

Commits
-------

065d28c Fix for #5783
@xabbuh xabbuh closed this as completed Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. DomCrawler good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
1 participant
@xabbuh