Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #5783 #5796

Closed
wants to merge 1 commit into from
Closed

Fix for #5783 #5796

wants to merge 1 commit into from

Conversation

BenjaminPaap
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to 2.8
Fixed tickets #5783

I can confirm, that this is the only place where the SplStorageObject and its methods which were marked as deprecated in symfony/symfony#15907 are referenced.

I can confirm, that this is the only place where the `SplStorageObject`
and its methods are referenced.
@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2015

Great 👍 Perfect pull request @BenjaminPaap! :)

@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2015

@javiereguiluz @wouterj @weaverryan I would like to merge this into the 2.3 branch. Using the methods inherited from the SplObjectStorage never was a good idea and I think we should not describe bad practices in any of our versions. What do you think?

@weaverryan
Copy link
Member

👍

@xabbuh
Copy link
Member

xabbuh commented Oct 19, 2015

Thank you Benjamin.

xabbuh added a commit that referenced this pull request Oct 19, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5796).

Discussion
----------

Fix for #5783

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.8
| Fixed tickets | #5783

I can confirm, that this is the only place where the `SplStorageObject` and its methods which were marked as deprecated in symfony/symfony#15907 are referenced.

Commits
-------

065d28c Fix for #5783
@xabbuh xabbuh closed this Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants