[Routing] Be consistent in custom route loader doc #11986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor ... but nice for consistency. Thanks Thomas! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 19, 2019
…yweb) This PR was merged into the 4.3 branch. Discussion ---------- [Routing] Be consistent in custom route loader doc To be consistent with the above name "The routes defined using service route loaders will be automatically..." + cf symfony/symfony#32598 (comment) Commits ------- d60e4f6 [Routing] Be consistent in custom route loader doc
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Jul 23, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Routing] Fix CHANGELOG | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Minor but cf symfony/symfony-docs#11986 - details make perfection 😁 Commits ------- 8b1d6cd [Routing] Fix CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent with the above name "The routes defined using service route loaders will be automatically..." + cf symfony/symfony#32598 (comment)