Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monolog] Add documentation about how to autowire monolog channels #12196

Conversation

adrenalinkin
Copy link
Contributor

@adrenalinkin adrenalinkin commented Aug 18, 2019

resolved: #12195

  • Added documentation about how to autowire monolog channels.

Relates to Symfony autowiring monolog channels

- Added documentation about how to autowire monolog channels.
@OskarStark OskarStark added this to the 4.3 milestone Aug 20, 2019
@xabbuh xabbuh added the Logger label Aug 26, 2019
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Sep 26, 2019
… monolog channels (adrenalinkin)

This PR was merged into the 4.3 branch.

Discussion
----------

[Monolog] Add documentation about how to autowire monolog channels

resolved: symfony#12195
- Added documentation about how to autowire monolog channels.

Relates to [Symfony autowiring monolog channels](symfony/monolog-bundle#315)

Commits
-------

2e5a627 ISSUE-12195: - Added documentation about how to autowire monolog channels.
@javiereguiluz
Copy link
Member

Viktor, thanks a lot for contributing this useful feature to the MonologBundle ... and thanks for contributing the docs too. Congrats by the way on your first Symfony Docs contribution!

While merging we reworded some things. We removed some of the versionadded directives you added. Why? Because "logging" is such a nice and simple concept that we use it casually in lots of articles to explain other things. So, I've removed the versionadded mentions in those articles which treated "logging" as a "casual" and unrelated thing ... I kept it in articles were logging is essential. Thanks!

@adrenalinkin adrenalinkin deleted the autowire_for_monolog_channels_4.3 branch September 26, 2019 19:20
@adrenalinkin
Copy link
Contributor Author

@javiereguiluz Good news! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants