[DependencyInjection] adjust Autowire attribute docs
#16779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
May 4, 2022
There was a problem hiding this comment.
I have a suggestion about this sentence:
"You can also use the #[Autowire] parameter attribute to configure the problematic arguments:"
I think it would be better to use the verb "hint" or "instruct" instead of "configure".
The reason is that "configure" is a bit overloaded here:
- configure service definitions explicitly
- configure the autowiring process (here we refer to this)
With this in mind, what about eg "You can also use the #[Autowire] parameter attribute to hint the autowiring logic about those arguments:"
|
I went with "instructs". |
nicolas-grekas
approved these changes
May 4, 2022
javiereguiluz
force-pushed
the
autowire-attr-adjust
branch
from
3ad96fd
to
fd05739
Compare
|
Thanks Kevin ... and thanks reviewers too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #16629 per slack discussion.
For services and expressions, explicitly use the named argument.