[Notifier] Add Ntfy bridge #18253
Merged
[Notifier] Add Ntfy bridge #18253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
OskarStark
reviewed
Apr 25, 2023
OskarStark
reviewed
Apr 25, 2023
OskarStark
changed the title
|
Would you open a PR against 5.4 branch for That would be helpful |
Only against 5.4 branch? Not 6.x other versions ? |
OskarStark
added a commit
that referenced
this pull request
Apr 26, 2023
|
@OskarStark : I will review this PR after merge of #18257 to only have addition of Ntfy bridge (not all bridges links) |
mikaelkael
changed the title
|
Rebase unlocked ✅ Thank you for the other Pr's 🙏 |
OskarStark
reviewed
Apr 26, 2023
OskarStark
approved these changes
Apr 26, 2023
OskarStark
approved these changes
Apr 28, 2023
notifier.rst
Outdated
| @@ -436,7 +437,7 @@ Service Package DSN | |||
|
|
|||
| .. versionadded:: 6.3 | |||
|
|
|||
| The PagerDuty and Pushover integrations were introduced in Symfony 6.3. | |||
| The Ntfy, PagerDuty and Pushover integrations were introduced in Symfony 6.3. | |||
There was a problem hiding this comment.
Please add a 6.4 block, as we are in feature freeze phase right now.
There was a problem hiding this comment.
@OskarStark : yes, I will review it when the 6.4 branch will be ready
OskarStark
reviewed
May 27, 2023
|
@OskarStark : doc PR against 6.4, code rebased for 6.4 and recipes added 😊 |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jun 20, 2023
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Notifier] add Ntfy bridge | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#18253 | Recipes PR | symfony/recipes#1204 Add [Ntfy](https://ntfy.sh/) notifier bridge Commits ------- c097511 [Notifier] add Ntfy bridge
OskarStark
approved these changes
Jul 4, 2023
javiereguiluz
added
Status: Reviewed
and removed
Status: Needs Review
Waiting Code Merge
javiereguiluz
force-pushed
the
ntfy-bridge
branch
from
cac7239
to
79d6e73
Compare
|
Merged! Thanks Mickael. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition with symfony/symfony#50131 for the new Ntfy notifier bridge