Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notifier] add Ntfy bridge #50131

Merged
merged 1 commit into from Jun 20, 2023
Merged

[Notifier] add Ntfy bridge #50131

merged 1 commit into from Jun 20, 2023

Conversation

mikaelkael
Copy link
Contributor

@mikaelkael mikaelkael commented Apr 23, 2023 •
edited by OskarStark

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#18253
Recipes PR symfony/recipes#1204

Add Ntfy notifier bridge

@carsonbot carsonbot added this to the 6.3 milestone Apr 23, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

OskarStark
OskarStark reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new bridge 👍🏻

src/Symfony/Component/Notifier/Bridge/Ntfy/NtfyOptions.php Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Ntfy/NtfyOptions.php Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Ntfy/NtfyTransport.php Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Ntfy/NtfyTransportFactory.php Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Ntfy/Tests/NtfyOptionsTest.php Show resolved Hide resolved
@mikaelkael
Copy link
Contributor Author

mikaelkael commented Apr 24, 2023 •
edited

@OskarStark : I exploded the modifications in 4 commits based on comments. Hope that's help for the review. Thanks!

In addition, a commit for the docs is ready (mikaelkael/symfony-docs@9507b06)

@OskarStark
Copy link
Contributor

Can please create a PR for the Symfony docs from your commit? Thanks

@mikaelkael mikaelkael mentioned this pull request Apr 25, 2023
Merged
@mikaelkael
Copy link
Contributor Author

Can please create a PR for the Symfony docs from your commit? Thanks

@OskarStark : it's done by symfony/symfony-docs#18253

@OskarStark OskarStark requested a review from fabpot April 25, 2023 06:49
@OskarStark
Copy link
Contributor

@fabpot this looks ready to merge from my side 👍

@fabpot
Copy link
Member

fabpot commented Apr 26, 2023

That will be for 6.4.

mikaelkael added a commit to mikaelkael/ntfy-notifier that referenced this pull request Apr 29, 2023
@mikaelkael
Apply same changes as in PR for 6.4 (symfony/symfony#50131)
aefb365
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@OskarStark
Copy link
Contributor

Please add a PR to symfony/recipes repository, thanks

@mikaelkael mikaelkael mentioned this pull request May 29, 2023
Merged
@fabpot
Copy link
Member

fabpot commented Jun 16, 2023

Now that the 6.4 branch is available, @mikaelkael can you rebase this PR so that we can merge it? Thank you.

@mikaelkael
Copy link
Contributor Author

Now that the 6.4 branch is available, @mikaelkael can you rebase this PR so that we can merge it? Thank you.

I did it 3 weeks ago but it was broken with the Novu integration few minutes ago. I rebased the 3 PR (code, docs and recipes) 😊

@OskarStark OskarStark changed the title [Notifier] add Ntfy Notifier Bridge [Notifier] add Ntfy bridge Jun 17, 2023
@fabpot
Copy link
Member

fabpot commented Jun 20, 2023

Thank you @mikaelkael.

@fabpot fabpot merged commit b51e2d3 into symfony:6.4 Jun 20, 2023
4 of 9 checks passed
@mikaelkael mikaelkael deleted the ntfy-notification branch June 20, 2023 16:47
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jul 4, 2023
@javiereguiluz
minor #18253 [Notifier] Add Ntfy bridge (mikaelkael)
55a46e7 
This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Notifier] Add Ntfy bridge

In addition with symfony/symfony#50131 for the new Ntfy notifier bridge

Commits
-------

79d6e73 [Notifier] Add Ntfy bridge
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikaelkael @carsonbot @OskarStark @fabpot @nicolas-grekas