Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scheduler] Fix scheduler examples #19440

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

alamirault
Copy link
Contributor

I tried to follow documentation and found some issues

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.4, 7.0, 7.1.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.3 milestone Jan 18, 2024
namespace App\Scheduler;

use Symfony\Component\Scheduler\Attribute\AsSchedule;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How code-block-checker can know theses classes ?

Is adding symfony/scheduler in its compoer.json will be enought ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this should be enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged

@carsonbot carsonbot changed the title Fix scheduler examples [Scheduler] Fix scheduler examples Jan 22, 2024
@javiereguiluz
Copy link
Member

Thank you Antoine.

@javiereguiluz javiereguiluz merged commit 83ab598 into symfony:6.3 Jan 22, 2024
2 of 3 checks passed
javiereguiluz added a commit that referenced this pull request Jan 22, 2024
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Scheduler] Document hashed Cron expression

Follow #19440

Try document symfony/symfony#49792

I copied a lot https://github.com/zenstruck/schedule-bundle/blob/1.x/doc/define-tasks.md#hashed-cron-expression

Commits
-------

f41721c [Scheduler] Document hashed Cron expression
@alamirault alamirault deleted the hotfix/scheduler branch January 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants