[Scheduler] Document hashed Cron expression #19441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
alamirault
commented
Jan 18, 2024
Comment on lines
+195
to
+196
| Hashed Cron Expression | ||
| ~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
I want to make a sub section, which char should I use ?
There was a problem hiding this comment.
We use the ........... separator for those sections. I did this while merging your PR.
|
|
||
| If you have many trigger scheduled at same time (for example, at midnight, ``0 0 * * *``) | ||
| this could create a very long running schedule right at this time. | ||
| This may cause an issue if a task has a memory leak. |
There was a problem hiding this comment.
I don't like this sentence. Maybe we should talk about real use case.
If I remember fabpot talk about email campaign
There was a problem hiding this comment.
what about writing bottle neck like lot of I/O, memory spike, etc etc?
94noni
reviewed
Jan 19, 2024
94noni
reviewed
Jan 19, 2024
94noni
reviewed
Jan 19, 2024
javiereguiluz
force-pushed
the
feature/scheduler-hashed-cron-expression
branch
from
12ffac5
to
f41721c
Compare
|
Merged! Thanks Antoine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #19440
Try document symfony/symfony#49792
I copied a lot https://github.com/zenstruck/schedule-bundle/blob/1.x/doc/define-tasks.md#hashed-cron-expression