Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more hints when using Symfony CLI in Windows #19754

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

llupa
Copy link
Contributor

@llupa llupa commented Apr 5, 2024

Maybe relevant: symfony-cli/symfony-cli#461

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this contribution. It explains the problem and the solution very clearly. I will wait some time before merging in case other users of WSL can comment on this.

Thanks @llupa

@llupa
Copy link
Contributor Author

llupa commented Apr 5, 2024

@javiereguiluz did a small proof-read update after @paullallier 's feedback. Thanks Paul!

setup/symfony_server.rst Outdated Show resolved Hide resolved
@javiereguiluz javiereguiluz modified the milestones: 7.1, 5.4 Apr 9, 2024
@javiereguiluz
Copy link
Member

This was a very nice contribution ... which was even improved a bit during the review process (thanks reviewers!)

@llupa thanks for this ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 5016d44 into symfony:5.4 Apr 9, 2024
3 checks passed
@llupa llupa deleted the symfony-cli branch June 10, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants