Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Update messenger.rst #19953

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[Messenger] Update messenger.rst #19953

merged 1 commit into from
Jun 12, 2024

Conversation

svdv22
Copy link
Contributor

@svdv22 svdv22 commented Jun 11, 2024

Was confused for a second because getBatchSize was introduced in 6.4 but according to the docs it wasn't used. It is according to the actual code so here's the fix.

See https://github.com/symfony/messenger/blob/6.4/Handler/BatchHandlerTrait.php#L58C9-L58C61

shouldFlush-method in documentation wasn't updatet
@carsonbot carsonbot added this to the 6.4 milestone Jun 11, 2024
@carsonbot carsonbot changed the title Update messenger.rst [Messenger] Update messenger.rst Jun 12, 2024
@javiereguiluz
Copy link
Member

Thanks @svdv22 and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 312603c into symfony:6.4 Jun 12, 2024
3 checks passed
@svdv22 svdv22 deleted the patch-1 branch June 19, 2024 06:24
javiereguiluz added a commit that referenced this pull request Jul 19, 2024
This PR was merged into the 6.4 branch.

Discussion
----------

[Messenger] use a custom batch size

reverts #19953 so that the code matches the comment above the method

Commits
-------

08f43e5 use a custom batch size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants