Add assetic DIC tags reference. #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| public function process(AssetInterface $asset) | ||
| { | ||
| // Change $asset or return a new one |
There was a problem hiding this comment.
// ... change $asset or return a new one
|
I think it's ready to be merged. And I'll add more description for |
weaverryan
added a commit
that referenced
this pull request
May 3, 2013
Add assetic DIC tags reference.
weaverryan
added a commit
that referenced
this pull request
May 3, 2013
|
Hi Pavel! Nice work with this - it's very nice! If you get more details about Thanks! |
weaverryan
added a commit
that referenced
this pull request
May 28, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one known issue is that the
assetic.assettag adds the asset to the asset manager, but AsseticBundle throws an exception when any asset has no associated formula. So at the moment this tag seems to be useless. I created an issue(symfony/assetic-bundle#183) in AsseticBundle. Once its filxed, I will add an example.