Add missing variable assignment #3537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 41 made use of $crawler which wasn't defined.
|
Thank you for submitting the fix! It should be merged into 2.3 (2.0, 2.1 and 2.2 are deprecated and no longer maintained). You don't have to create your PR again, @weaverryan (who will merge your PR) can cherry pick it quite easily in the correct branch. |
|
Yes, very good mistake fix :). Thanks Colin! |
|
@weaverryan, will this be merged into the 2.4 branch as well? |
|
@colinodell Yes it will! We merge 2.3 into 2.4 into master. It doesn't happen after every merge - but happens about once a week :). |
weaverryan
added a commit
that referenced
this pull request
Feb 16, 2014
…er (colinodell) This PR was merged into the 2.3 branch. Discussion ---------- Fix README: contributions should be based off 2.3 or higher Per [the documentation](http://symfony.com/doc/current/contributing/documentation/overview.html#contributing) and [WouterJ's comment here](#3537 (comment)), the base branch should be 2.3, not 2.2. This commit updates the README to reflect the language found in the documentation. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a Commits ------- ed5eab7 Contributions should be based off 2.3 or higher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 41 made use of $crawler which wasn't defined.