Fix representation #4703
Merged
Fix representation #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be just me, but with `unless` it sounds like **if you want to use your forms in multiple places you should define it in your controllers**. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |
|
I think it's clear the way it is currently? What do others feel about it (especially other non-native speakers)? |
|
i think @xabbuh is right, we dont need to change this. |
|
In my opinion @ifdattic's version is easier to understand. |
|
I agree with @ifdattic too. @weaverryan can you please decide and merge (or not)? |
|
Let's change it then if the majority feels that it is more clear this way. 👍 |
| @@ -13,7 +13,7 @@ Building Forms | |||
| Define your forms as PHP classes. | |||
|
|
|||
| The Form component allows you to build forms right inside your controller | |||
| code. Honestly, unless you need to reuse the form somewhere else, that's | |||
| code. Honestly, if you don't need to reuse the form somewhere else, that's | |||
There was a problem hiding this comment.
I think the original is more clear, but I see your point. How about:
And if you don't need to reuse the form in multiple places, that's totally fine.
There was a problem hiding this comment.
Then it becomes a bit unclear where "that" is refering too. What about:
The Form component allows you to build forms right inside your controller code. This is
perfectly fine if you don't need to reuse the form somewhere else.
There was a problem hiding this comment.
👍 should I change it?
|
Awesome - thanks for the last update :) |
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Fix representation It might be just me, but with `unless` it sounds like **if you want to use your forms in multiple places you should define it in your controllers**. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Commits ------- 6a55617 Update forms.rst 3d62349 Fix representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be just me, but with
unlessit sounds like if you want to use your forms in multiple places you should define it in your controllers.