[#4231] Clarify that only the main command triggers events #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
riperez
commented
Feb 6, 2015
riperez
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #4231 |
|
This is my first contribution so please be kind to me ;) |
| @@ -20,6 +20,11 @@ the wheel, it uses the Symfony EventDispatcher component to do the work:: | |||
| $application->setDispatcher($dispatcher); | |||
| $application->run(); | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| Console application lifecycle events are only triggered by the main command being executed. Inner or nested | |||
There was a problem hiding this comment.
I think we should call them "Console events" (just like we did in the versionadded directive).
|
It's a very good start! Correct branch, fixing a ticket, using correct syntax, etc. Great! Besides my two pretty minor comments above, you should add a line break after the first word that crosses the 72th character. This does include the 4 spaces of indent. |
riperez
force-pushed
the
clarify_who_triggers_events_on_commands
branch
from
3f18fac
to
3f5ce4d
Compare
|
Second version following @wouterj advice. Thanks for the help! |
|
👍 from me |
|
@riperez Looks great to me too. 👍 |
|
Looks perfect to me! Thanks Richard for the PR. Always even better to have a PR that closes an issue too :). Cheers! |
weaverryan
added a commit
that referenced
this pull request
Feb 24, 2015
…nts (riperez) This PR was merged into the 2.3 branch. Discussion ---------- [#4231] Clarify that only the main command triggers events | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4231 Commits ------- 3f5ce4d [#4231] Clarify that only the main command triggers events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.