Added a note about the rotating_file monolog handler #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Apr 2, 2015
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | all |
| Fixed tickets | #1161 |
| main: | ||
| type: rotating_file # <-- this value is usually 'stream' | ||
| path: %kernel.logs_dir%/%kernel.environment%.log | ||
| level: debug |
There was a problem hiding this comment.
you need to add XML and PHP:
<!-- app/config/config_dev.xml -->
<?xml version="1.0" charset="UTF-8" ?>
<container xmlns=''http://symfony.com/schema/dic/services"
xmlns:monolog="http://symfony.com/schema/dic/monolog">
<monolog:config>
<monolog:handler name="main"
type="rotating_file"
path="%kernel.logs_dir%/%kernel.environment%.log"
level="debug"
/>
</monolog:config>
</container>// app/config/config_dev.php
$container->loadFromExtension('monolog', array(
'handlers' => array(
'main' => array(
'type' => 'rotating_file',
'path' => '%kernel.logs_dir%/%kernel.environment%.log',
'level' => 'debug',
),
),
));There was a problem hiding this comment.
Thanks for reminding me about this! Done in 7345c17.
| main: | ||
| type: rotating_file | ||
| path: %kernel.logs_dir%/%kernel.environment%.log | ||
| level: debug |
There was a problem hiding this comment.
I think we should show max_files - maybe commented out, with a comment above/on the line that says it defaults to zero (infinite)
and explained the max_files configuration option
|
I've just implemented the suggestions made by @weaverryan. Can this be considered finished now? |
|
👍 |
1 similar comment
|
👍 |
weaverryan
added a commit
that referenced
this pull request
May 25, 2015
…aviereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Added a note about the rotating_file monolog handler | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | #1161 Commits ------- db1e798 Created a new section for rotating log files and explained the max_files configuration option 7345c17 Added XML and PHP configuration samples 31fd0db Added a note about the rotating_file monolog handler
|
Thanks Javier! I took some liberty in re-wording the paragraph to be slightly shorter - but please let me know if anyone thinks I've changed any meaning or anything with it - sha: e7c984f Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.