Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase #4633 #5280

Closed
wants to merge 1 commit into from
Closed

Rebase #4633 #5280

wants to merge 1 commit into from

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented May 21, 2015

Original description: #4633

Simple change...would have saved me several hours of guessing.

@seangallavan @wouterj
Update data_collector.rst
229705e 
Simple change...would have saved me several hours of guessing.
@wouterj wouterj mentioned this pull request May 21, 2015
Closed
@xabbuh
Copy link
Member

xabbuh commented May 22, 2015

👍 But should be merged into 2.3, shouldn't it?

@weaverryan
Copy link
Member

👍 merged to 2.3!

weaverryan added a commit that referenced this pull request May 23, 2015
@weaverryan
minor #5280 Rebase #4633 (seangallavan)
2fc4b10 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5280).

Discussion
----------

Rebase #4633

Original description:

 > Simple change...would have saved me several hours of guessing.

Commits
-------

9de2017 Update data_collector.rst
@weaverryan weaverryan closed this May 23, 2015
@wouterj wouterj deleted the seangallavan-patch-1 branch May 23, 2015 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wouterj @xabbuh @weaverryan @seangallavan