Reworded the "How to use Gmail" cookbook article #5856
Conversation
| @@ -55,33 +50,73 @@ In the development configuration file, change the ``transport`` setting to | |||
| 'password' => 'your_gmail_password', | |||
| )); | |||
|
|
|||
| You're done! | |||
| If you are using the Symfony Standard Edition, it's more convenient to configure | |||
| these parameters in ``parameters.yml``: | |||
There was a problem hiding this comment.
"these parameters" seems wrong, as we never talked about parameters before in this article. What about: "If you're using the Symfony Standard Edition, it's more convenient to use parameters for these options:"
There was a problem hiding this comment.
...to use parameters.yml for these options...?
| .. note:: | ||
| The ``gmail`` transport is simply a shortcut that uses the ``smtp`` transport | ||
| and sets ``encryption`` to ``ssl``, ``auth_mode`` to ``login`` and ``host`` to | ||
| ``smtp.gmail.com`` to work with Gmail. |
There was a problem hiding this comment.
what about using a table here for the options?
|
Great work @javiereguiluz |
|
I've changed everything I was asked for. Time for another review. Thanks. |
|
nice 👍 |
|
|
||
| The ``gmail`` transport is simply a shortcut that uses the ``smtp`` transport | ||
| and sets ``encryption``, ``auth_mode`` and ``host`` to work with Gmail. | ||
| If you are using 2-Step-Verification, you must `generate an App password`_ and use this as your ``mailer_password`` value. |
There was a problem hiding this comment.
looks like you forgot to wrap the sentence :)
|
I've implemented the last round of fixes. Please tell me that this is ready for the merge 😌 |
| within your app. If your Gmail account uses 2-Step-Verification, you should | ||
| `generate an App password`_ to use for your ``mailer_password`` parameter. | ||
| You should also ensure that you `allow less secure apps to access your Gmail account`_. | ||
| :doc:`Swiftmailer configuration reference </reference/configuration/swiftmailer>` |
There was a problem hiding this comment.
I would have kept the sentence though:
.. seealso::
See the :doc:`Swiftmailer configuration reference </reference/configuration/swiftmailer>`
for more details.There was a problem hiding this comment.
But we can make that change when merging. The PR so far looks ready to me. 👍
…reguiluz) This PR was squashed before being merged into the 2.3 branch (closes #5856). Discussion ---------- Reworded the "How to use Gmail" cookbook article | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - In StackOverflow some people are [having issues](http://stackoverflow.com/questions/33226583/swiftmailer-doesnt-work/33240538#33240538) with the `encryption` parameter of Gmail. And others are [having issues](symfony/swiftmailer-bundle#106) with Gmail + SwiftMailerBundle. That's why I propose to reword this article and explain some things with more detail. Commits ------- b113f72 Reworded the "How to use Gmail" cookbook article
|
Thank you @javiereguiluz! I've merged your PR and applied the final 2 comments in 6c07b60 |
In StackOverflow some people are having issues with the
encryptionparameter of Gmail. And others are having issues with Gmail + SwiftMailerBundle.That's why I propose to reword this article and explain some things with more detail.