Add isSubmitted call #5972
Closed
Add isSubmitted call #5972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamline with http://symfony.com/doc/current/book/forms.html#handling-form-submissions Following best practice: http://symfony.com/doc/current/best_practices/forms.html
|
@DanielSiepmann thanks for submitting this fix. I agree that we should comply with the best practices here. By the way, could you please swap the order of the methods: if ($form->isSubmitted() && $form->isValid()) { |
To follow best practice swap order of calls.
|
👍 |
|
Thanks, I've updated that and will match the order in #5970, too. |
|
👍 |
|
Thanks for your quick reactions Daniel! I've now merged this into the 2.3 docs and will merge it into the latest versions from there (fyi, that's why this PR is marked as closed). |
wouterj
added a commit
that referenced
this pull request
Dec 7, 2015
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #5972). Discussion ---------- Add isSubmitted call Streamline with http://symfony.com/doc/current/book/forms.html#handling-form-submissions Following best practice: http://symfony.com/doc/current/best_practices/forms.html Commits ------- d8c93e2 Add isSubmitted call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamline with http://symfony.com/doc/current/book/forms.html#handling-form-submissions
Following best practice: http://symfony.com/doc/current/best_practices/forms.html