Remove isSubmitted call #5970
Closed
Remove isSubmitted call #5970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamline with http://symfony.com/doc/current/book/forms.html#handling-form-submissions There is no need for `isSubmitted` as this is done inside `isValid`
|
But this is intended, because is considered a best practice. http://symfony.com/doc/current/best_practices/forms.html
|
|
Okay ... but then this should be changed in the referenced documentation http://symfony.com/doc/current/book/forms.html#handling-form-submissions, shouldn't it? |
|
Yes, you're right. If you can do it would be great! |
|
Done within #5972 I'll close this pull request. |
Closed
To follow best practice swap order of calls.
|
Following #5972 I've swapped the order of call. |
|
👍 |
|
Great, thanks Daniel! |
wouterj
added a commit
that referenced
this pull request
Dec 7, 2015
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #5970). Discussion ---------- Remove isSubmitted call Streamline with http://symfony.com/doc/current/book/forms.html#handling-form-submissions There is no need for `isSubmitted` as this is done inside `isValid` Commits ------- cebd5fd Remove isSubmitted call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamline with http://symfony.com/doc/current/book/forms.html#handling-form-submissions
There is no need for
isSubmittedas this is done insideisValid