-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form] fix 'data_class' option in EntityType #6267
Conversation
@@ -21,6 +20,7 @@ objects from the database. | |||
+-------------+------------------------------------------------------------------+ | |||
| Overridden | - `choice_list`_ | | |||
| options | - `choices`_ | | |||
| | - `data_class`_ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove two spaces before the last pipe character.
The first |
b67b0f6
to
220b5e9
Compare
@xabbuh thank you, fixed ! |
em | ||
~~ | ||
|
||
**type**: ``string`` **default**: the default entity manager | ||
**type**: ``string`` **default**: the default entity manager class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this option can be a string. But then it is the manager name not the class name. Additionally, you can also pass . ObjectManager
instances here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xabbuh, thanks, now understood and fixed !
220b5e9
to
2ac70f7
Compare
👍 |
Thank you Jules. |
This PR was merged into the 2.3 branch. Discussion ---------- [Form] fix 'data_class' option in EntityType `data_class` option in kind of overridden as it is not used in `EntityType` in favor of required `class` option. Commits ------- 2ac70f7 fix 'data_class' option in EntityType
data_class
option in kind of overridden as it is not used inEntityType
in favor of requiredclass
option.