Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change isValid to isSubmitted. #6281

Closed
wants to merge 1 commit into from
Closed

Change isValid to isSubmitted. #6281

wants to merge 1 commit into from

Conversation

mustafaaloko
Copy link
Contributor

Fixed this line: isValid() returns false if the form was not submitted.
To this: isSubmitted() returns false if the form was not submitted.

@javiereguiluz
Copy link
Member

👍 @mustafaaloko thanks for this nice catch!

@javiereguiluz
Copy link
Member

(Note to doc managers: this change has to be merged in 2.3 branch)

@wouterj
Copy link
Member

wouterj commented Feb 22, 2016

Both isValid() and isSubmitted() return false if the form was not submitted. The extra call is there purely for more clarity. I think it is important to mention that isValid() also returns false when the form was not submitted. However, I also agree with your change: 👍

@xabbuh
Copy link
Member

xabbuh commented Feb 22, 2016

Should we update the following two items too to make the text more consistent (both refer to isValid() and the wording now doesn't perfectly match anymore with the changes to this item imo)?

wouterj added a commit that referenced this pull request Mar 5, 2016
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #6281).

Discussion
----------

Change isValid to isSubmitted.

Fixed this line: `isValid()` returns false if the form was not submitted.
To this: `isSubmitted()` returns false if the form was not submitted.

Commits
-------

f44ec98 Change isValid to isSubmitted.
wouterj added a commit that referenced this pull request Mar 5, 2016
@wouterj
Copy link
Member

wouterj commented Mar 5, 2016

Thank you @mustafaaloko! I've merged your changes into the 2.3 branch (I'll merge it to others from there). As suggested by @xabbuh, I've also reworded the next 2 items a little bit in 934aad5. I kept the isValid calls, as they are about validation.

@wouterj wouterj closed this Mar 5, 2016
@mustafaaloko
Copy link
Contributor Author

👍

@mustafaaloko mustafaaloko deleted the patch-1 branch March 6, 2016 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants