[Validator] Added docs about the format option #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dosten
commented
Mar 1, 2016
dosten
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes, see symfony/symfony#17553 |
| Applies to | 3.1+ |
| Fixed tickets | #6313 |
|
ping @xabbuh |
| .. versionadded:: 3.1 | ||
| The ``format`` option was introduced in Symfony 3.1. | ||
|
|
||
| This option allows to validate a custom date format. See `date_create_from_format`_ for formatting options. |
There was a problem hiding this comment.
I would change the label to DateTime:createFromFormat():
See `DateTime::createFromFormat <date_create_from_format>`_ for [...]
|
@xabbuh comments addressed |
| .. versionadded:: 3.1 | ||
| The ``format`` option was introduced in Symfony 3.1. | ||
|
|
||
| This option allows to validate a custom date format. See `DateTime::createFromFormat <date_create_from_format>`_ for formatting options. |
There was a problem hiding this comment.
Can you please the line after the first word that crosses the 72nd character?
|
👍 I just left some very minor comment. |
|
@xabbuh done |
|
Great! :) |
wouterj
added a commit
that referenced
this pull request
Mar 5, 2016
This PR was merged into the master branch. Discussion ---------- [Validator] Added docs about the format option | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes, see symfony/symfony#17553 | Applies to | 3.1+ | Fixed tickets | #6313 Commits ------- f8d1e82 Added docs about the format option
wouterj
added a commit
that referenced
this pull request
Mar 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.