Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration.rst typo #6337

Closed
wants to merge 1 commit into from
Closed

Fix configuration.rst typo #6337

wants to merge 1 commit into from

Conversation

gong023
Copy link
Contributor

@gong023 gong023 commented Mar 6, 2016

$ecret seems to be typo

@gong023
Fix configuration.rst typo
5824544 
`$ecret` seems to be typo
@wouterj
Copy link
Member

wouterj commented Mar 7, 2016

Hmm, this is a fun one (if I may say). As a plain "secret" string is not that secret, we replaced the "s" with the dollar sign resulting in $ecret. However, I understand why this can be extremely confusing.

I've merged this PR into the 2.3 branch (which, btw, caused the closed status of this PR instead of merged) and changed it to your_secret to avoid further confusion. Thanks for reporting this and submitting a possible fix!

wouterj added a commit that referenced this pull request Mar 7, 2016
@wouterj
minor #6337 Fix configuration.rst typo (gong023)
71c6414 
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6337).

Discussion
----------

Fix configuration.rst typo

`$ecret` seems to be typo

Commits
-------

129c707 Fix configuration.rst typo
wouterj added a commit that referenced this pull request Mar 7, 2016
@wouterj
[#6337] Change value of client_secret option
c63c826
@wouterj wouterj closed this Mar 7, 2016
@gong023
Copy link
Contributor Author

gong023 commented Mar 7, 2016

At first I also thought $ecret was a joke. But actually, $secret and $ecret were mixed before I sent this pull request. So I was confused.
Thank you for your reviewing!

@xabbuh xabbuh mentioned this pull request Apr 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gong023 @wouterj