Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed wrong secret string in array examples #6482

Closed
wants to merge 1 commit into from

Conversation

OskarStark
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to 2.7+
Fixed tickets --

Looks like this is a copy paste error from older doc versions where the string $ecret was used.

This needs to be applied to all branches from 2.7 on

Check the old version of the docs here where the $ecret string is used:
http://symfony.com/doc/2.6/cookbook/bundles/configuration.html

@OskarStark
Copy link
Contributor Author

ping @xabbuh

@xabbuh
Copy link
Member

xabbuh commented Apr 18, 2016

👍

Indeed, we made that change in #6337 (and the following commit c63c826), but forgot to update all places.

@wouterj
Copy link
Member

wouterj commented Apr 18, 2016

Thanks Oskar!

wouterj added a commit that referenced this pull request Apr 18, 2016
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #6482).

Discussion
----------

fixed wrong secret string in array examples

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7+
| Fixed tickets | --

Looks like this is a copy paste error from older doc versions where the string `$ecret` was used.

This needs to be applied to all branches from 2.7 on

Check the old version of the docs here where the `$ecret` string is used:
http://symfony.com/doc/2.6/cookbook/bundles/configuration.html

Commits
-------

f7950ab fixed wrong secret string in array examples
@wouterj wouterj closed this Apr 18, 2016
wouterj added a commit to wouterj/symfony-docs that referenced this pull request Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants