Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[book] Updated link to Translatable Extension #6362

Merged
merged 2 commits into from
Mar 17, 2016
Merged

Conversation

a-ast
Copy link
Contributor

@a-ast a-ast commented Mar 13, 2016

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets n/a

Since l3pp4rd project was moved it is better to provide link to the new project. Moreover, I think it is better to show the exact page of Translatable Extension instead of a list of extensions.

Since l3pp4rd project was moved it is better to provide link to the new project. Moreover, I think it is better to show the exact page of Translatable Extension instead of a list of extensions.
@javiereguiluz
Copy link
Member

A quick win and a nice improvement! @AAstakhov thanks for helping us improve the Symfony docs.

@xabbuh
Copy link
Member

xabbuh commented Mar 13, 2016

Thanks for the heads up @AAstakhov. However, I'd say let's link to the rendered docs on http://atlantic18.github.io/DoctrineExtensions/doc/translatable.html.

Replaced link to Translatable Extension to rendered documentation.
@a-ast
Copy link
Contributor Author

a-ast commented Mar 13, 2016

@xabbuh, agree

@xabbuh
Copy link
Member

xabbuh commented Mar 13, 2016

👍

@webda2l
Copy link
Contributor

webda2l commented Mar 14, 2016

I don't think promote the old (and buggy) Gedmo implementation is a good idea, KNP is simpler and better.

@xabbuh
Copy link
Member

xabbuh commented Mar 14, 2016

@webda2l Would you like to open a new issue for that? We can, of course, discuss to promote another library but we should discuss that apart from this PR which just fixes the link.

@webda2l
Copy link
Contributor

webda2l commented Mar 14, 2016

This is just that this PR "Updated link" could become "Remove link", but more people should give their opinion.
But let's merge this PR for now if you want, no problem.

@weaverryan
Copy link
Member

Perhaps @docteurklein can tell us about https://github.com/KnpLabs/DoctrineBehaviors and it we should link there instead - I have also heard good things :)

@weaverryan weaverryan merged commit b273c67 into symfony:2.3 Mar 17, 2016
weaverryan added a commit that referenced this pull request Mar 17, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

[book] Updated link to Translatable Extension

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | n/a

Since l3pp4rd project was moved it is better to provide link to the new project. Moreover, I think it is better to show the exact page of Translatable Extension instead of a list of extensions.

Commits
-------

b273c67 Updated link to Translatable Extension
b4adf83 Updated link to Translatable Extension
@docteurklein
Copy link
Contributor

I didn't have a good experience with gedmo translation (specifically) extension neither.
It used to denormalize data in a bad way by default (one single big table).

KnpLabs/DoctrineBehaviors tries to stick as much as possible to use ORM associations.
We just add metadata on the fly (via onLoadMetadata event) and add a few model methods via a trait.

I'm not sure about the other behaviors in the same package (softDeletable f.e), but translatable is pretty solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants