Fix console.exception and console.terminate order #6631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 this is easy to check: https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Console/Application.php#L859-877 @julienfalque thanks. |
xabbuh
added a commit
that referenced
this pull request
Jun 6, 2016
… Falque) This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #6631). Discussion ---------- Fix console.exception and console.terminate order The `ConsoleEvents::TERMINATE`event is actually dispatched **after** the `ConsoleEvents::EXCEPTION` event in Symfony 2.3 and 2.7+. Commits ------- 608747a Fix console.exception and console.terminate order
|
Thank you @michaeldegroot. I have merged your change into the |
xabbuh
added a commit
to xabbuh/symfony-docs
that referenced
this pull request
Jun 6, 2016
In symfony#6631 we already fixed a sentence in the description. This change will also reflect the occurence of the events by the order in which their descriptions are shown.
|
I think we could now also swap the descriptions of these two events entirely (see #6638). |
wouterj
added a commit
that referenced
this pull request
Jun 12, 2016
This PR was merged into the 2.7 branch. Discussion ---------- swap terminate and exception event descriptions In #6631 we already fixed a sentence in the description. This change will also reflect the occurence of the events by the order in which their descriptions are shown. Commits ------- c74aa41 swap terminate and exception event descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConsoleEvents::TERMINATEevent is actually dispatched after theConsoleEvents::EXCEPTIONevent in Symfony 2.3 and 2.7+.