Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap terminate and exception event descriptions #6638

Merged
merged 1 commit into from
Jun 12, 2016
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 6, 2016

In #6631 we already fixed a sentence in the description. This change
will also reflect the occurence of the events by the order in which
their descriptions are shown.

In symfony#6631 we already fixed a sentence in the description. This change
will also reflect the occurence of the events by the order in which
their descriptions are shown.
@javiereguiluz
Copy link
Member

👍 it totally makes sense!

@javiereguiluz
Copy link
Member

Status: Reviewed

@wouterj
Copy link
Member

wouterj commented Jun 12, 2016

Thanks!

@wouterj wouterj merged commit c74aa41 into symfony:2.7 Jun 12, 2016
wouterj added a commit that referenced this pull request Jun 12, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

swap terminate and exception event descriptions

In #6631 we already fixed a sentence in the description. This change
will also reflect the occurence of the events by the order in which
their descriptions are shown.

Commits
-------

c74aa41 swap terminate and exception event descriptions
@xabbuh xabbuh deleted the pr-6631 branch June 13, 2016 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants