Remove colloquialism "hold on" #6805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm of the thought that documentation should balance between conversational grammar and formal grammar. Hold on pushes that over the conversational boundary, in my opinion. Thoughts?
| @@ -32,8 +32,8 @@ take a look at the :doc:`Form Events </form/events>` documentation. | |||
| Customizing your Form Based on the Underlying Data | |||
| -------------------------------------------------- | |||
|
|
|||
| Before jumping right into dynamic form generation, hold on and recall what | |||
There was a problem hiding this comment.
I agree on the tone which is slightly different here compared to the rest of the documentation.
If hold on is removed I think jumping right into should also be changed as it relates to each other.
There was a problem hiding this comment.
I agree. I'll think of something in place of jumping right into and update the PR.
|
👍 Status: Reviewed Thanks @micheal |
Re-add the :: and change the wording for `jumping right into`.
|
Thanks. I've updated as per above. |
|
Right or wrong, I prioritize language that i be energetic and engaging, above formal or informal. But, that's just my opinion, and I don't think this modification is less energetic/engaging anyways. Thanks @micheal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm of the thought that documentation should balance between conversational grammar and formal grammar. Hold on pushes that over the conversational boundary, in my opinion. Thoughts?