Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to profiler lifetime property that was removed in 3.x #6903

Closed
wants to merge 2 commits into from
Closed

Remove reference to profiler lifetime property that was removed in 3.x #6903

wants to merge 2 commits into from

Conversation

jameshalsall
Copy link
Contributor

@jameshalsall jameshalsall commented Aug 22, 2016 •
edited
Loading

Fixes #6889

@jameshalsall jameshalsall changed the title Remove reference to profiler lifetime property that was remove in 3.x Remove reference to profiler lifetime property that was removed in 3.x Aug 22, 2016
@stof
Copy link
Member

stof commented Aug 22, 2016

username and password are gone as well

@wouterj
Copy link
Member

wouterj commented Aug 23, 2016

👍 Thanks for updating these! We should also create another PR to add a .. caution:: box that this options are deprecated and will be removed in Symfony 3.

status: reviewed

@jameshalsall
Copy link
Contributor Author

I'll create another PR for the caution boxes

@jameshalsall jameshalsall mentioned this pull request Aug 23, 2016
Closed
wouterj added a commit that referenced this pull request Aug 26, 2016
@wouterj
feature #6908 Add deprecation warnings to relevant profiler options (…
5aeec90 
…jameshalsall)

This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #6908).

Discussion
----------

Add deprecation warnings to relevant profiler options

Related to #6903

Commits
-------

09ecf5f Add deprecation warnings to relevant profiler options
@wouterj
Copy link
Member

wouterj commented Aug 26, 2016

Thanks! This one is now merged as well.

wouterj added a commit to wouterj/symfony-docs that referenced this pull request Aug 26, 2016
@wouterj
feature symfony#6903 Remove reference to profiler lifetime property t…
b2125c0 
…hat was removed in 3.x (jameshalsall)

This PR was squashed before being merged into the 3.0 branch (closes symfony#6903).

Discussion
----------

Remove reference to profiler lifetime property that was removed in 3.x

Fixes symfony#6889

Commits
-------

c084375 Remove reference to profiler lifetime property that was removed in 3.x
@wouterj wouterj closed this Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jameshalsall @stof @wouterj @carsonbot