Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings to relevant profiler options #6908

Conversation

jameshalsall
Copy link
Contributor

Related to #6903

@wouterj
Copy link
Member

wouterj commented Aug 23, 2016

👍
status: reviewed

Thanks for your quick actions!

@wouterj
Copy link
Member

wouterj commented Aug 26, 2016

Thanks again James! It's now merged, will merge your other PR now as well.

wouterj added a commit that referenced this pull request Aug 26, 2016
…jameshalsall)

This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #6908).

Discussion
----------

Add deprecation warnings to relevant profiler options

Related to #6903

Commits
-------

09ecf5f Add deprecation warnings to relevant profiler options
@wouterj wouterj closed this Aug 26, 2016
weaverryan added a commit that referenced this pull request Sep 18, 2016
* 2.8: (32 commits)
  [#6925] Removing more instances of the deprecated getMock()
  Method "$this->getMock()" is depreciated
  Minor language tweaks
  removing cookbook entries
  updating links
  Moving files into the new structure
  [#6649] Changing a note to a caution - this *is* a gotcha
  fix typo
  Typo in the class name.
  Update tags.rst
  Fixed indentation issues in alias_private article
  Fix the error in code example
  [Controller Description] Remove backticks
  [Controller] Fix nested inline markup
  [Controller Description] Fix typos and class link
  Fix var_dumper advanced usage link
  [#6908] Add deprecations on some other places as well
  Add deprecation warnings to relevant profiler options
  Update access_control.rst
  DumpFile() third argument is deprecated and doesn't exists anymore in 3.x
  ...
xabbuh added a commit that referenced this pull request Sep 21, 2016
This PR was merged into the 2.8 branch.

Discussion
----------

[Reference] add back the option's description

This was accidentally removed in #6908 when the deprecation warnings were added.

Commits
-------

9e56a2b add back the option's description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants