[Guard] Improve clarity using the configured provider #6931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice feedback, I agree with you: 👍 |
|
Thank you @chalasr. |
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
…alasr) This PR was merged into the 2.8 branch. Discussion ---------- [Guard] Improve clarity using the configured provider Recently at work, a colleague trying to discover Guard said me how it was confused by the given example: > Does Guard require to configure an user provider, or can I simply inject the entity manager? Otherwise, what is the point of configuring this provider? I think I understand why this example was made as is, showing the flexibility of Guard and its ability to answer different needs in different authentication ways without going deeper into things that are already documented somewhere else. On the other hand I can understand it's confusing and IMHO remove the use of the entity manager can make it clearer and easier to understand. Note that the current example shouldn't work as is, as don't set the `property` key of an entity provider involves to create a doctrine repository implementing `UserLoaderInterface` for the corresponding `User` entity (if the provider comes to be used of course). What do you think? ping @weaverryan Commits ------- 456dc05 [Guard] Improve clarity using the configured provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently at work, a colleague trying to discover Guard said me how he was confused by the given example:
I think I understand why this example was made as is, showing the flexibility of Guard and its ability to answer different needs in different authentication ways without going deeper into things that are already documented somewhere else.
On the other hand I can understand it's confusing and IMHO remove the use of the entity manager can make it clearer and easier to understand.
Note that the current example shouldn't work as is, as don't set the
propertykey of an entity provider involves to create a doctrine repository implementingUserLoaderInterfacefor the correspondingUserentity (if the provider comes to be used of course).What do you think?
ping @weaverryan