Update form_dependencies.rst: fix DI #7009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix service definitions for `__construct(EntityManager $em)` argument
|
👍 Status: Reviewed |
|
Good catch, thanks @ReDnAxE. |
|
@xabbuh sorry, but why this PR has been closed without being merged ? |
|
@ReDnAxE This PR says "closed" because it was merged in 2.7 the oldest maintained branch needing that fix but was targeting master. It will be merged in newer branches from there. |
|
@ReDnAxE Oh sorry, I didn't want to shock you. But @HeahDude explained our process very well. :) We always merge PRs into the lowest affected branch that is still supported and then frequently merge things up from there to master. So your changes will also be available soon on all other branches. :) |
|
@xabbuh my fault ;) indeed I knew it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix service definitions for
__construct(EntityManager $em)argument