[Fix][httpKernel] Wrong links #7308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bad links pointing to the HttpKernel api.
javiereguiluz
requested changes
Jan 2, 2017
| @@ -124,9 +124,9 @@ For general information on adding listeners to the events below, see | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| As of 3.1 the :class:`Symfony\\Component\\Httpkernel\\HttpKernel` accepts a | |||
| As of 3.1 the :class:`Symfony\\Component\\HttpKernel` accepts a | |||
There was a problem hiding this comment.
I'd say that the original reference was correct (except for the uppercase/lowercase problem, of course). See: http://api.symfony.com/3.1/Symfony/Component/HttpKernel/HttpKernel.html
| fourth argument, which must be an instance of | ||
| :class:`Symfony\\Component\\Httpkernel\\Controller\\ArgumentResolverInterface`. | ||
| :class:`Symfony\\Component\\HttpKernel\\Controller\\ArgumentResolverInterface`. |
Fix - wrong way
|
Thanks @javiereguiluz, Indeed I have done wrong. |
javiereguiluz
approved these changes
Jan 3, 2017
|
Thank you @20uf. |
xabbuh
added a commit
that referenced
this pull request
Jan 10, 2017
This PR was submitted for the 3.2 branch but it was merged into the 3.1 branch instead (closes #7308). Discussion ---------- [Fix][httpKernel] Wrong links Hello here, ### Problem Fixes bad links pointing to the HttpKernel api. http://symfony.com/doc/current/components/http_kernel.html#the-kernel-request-event Happy New Year ! Commits ------- 3992434 [Fix][httpKernel] Wrong links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello here,
Problem
Fixes bad links pointing to the HttpKernel api.
http://symfony.com/doc/current/components/http_kernel.html#the-kernel-request-event
Happy New Year !