Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented the new getProjectDir() method #7810

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #7768.

@@ -56,6 +56,10 @@ directory and rename it to something else (e.g. ``foo``).
Root Directory
~~~~~~~~~~~~~~

.. versionadded:: 3.3
The ``getRootDir()`` method was deprecated in Symfony 3.3 and replaced by
the new ``getProjectDir()`` method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "The getRootDir() method is deprecated since Symfony 3.3. Use the new getProjectDir() method instead."?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 much better. Thanks!

@linaori
Copy link
Contributor

linaori commented Apr 19, 2017

@@ -56,6 +56,10 @@ directory and rename it to something else (e.g. ``foo``).
Root Directory
~~~~~~~~~~~~~~

.. versionadded:: 3.3
The ``getRootDir()`` method is deprecated since Symfony 3.3. Use the new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not been deprecated yet, have I missed that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. versionadded:: 3.3
The ``getProjectDir()`` method was introduced in Symfony 3.3.

**type**: ``string`` **default**: the directory of the project ``composer.json``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"project's"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The genitive is not common for non-living things:

We normally use the ’s with people, animals though it can also be used with places, organizations and companies (which suggest a group of people).

It is not common to use the ’s with non-living things.

Source: http://www.grammar.cl/rules/genitive-case.htm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Method: Kernel::getProjectDir()
5 participants