-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented the new getProjectDir() method #7810
Conversation
reference/configuration/kernel.rst
Outdated
@@ -56,6 +56,10 @@ directory and rename it to something else (e.g. ``foo``). | |||
Root Directory | |||
~~~~~~~~~~~~~~ | |||
|
|||
.. versionadded:: 3.3 | |||
The ``getRootDir()`` method was deprecated in Symfony 3.3 and replaced by | |||
the new ``getProjectDir()`` method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about "The getRootDir()
method is deprecated since Symfony 3.3. Use the new getProjectDir()
method instead."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 much better. Thanks!
I'm missing a mention of https://github.com/symfony/symfony/pull/22315/files#diff-50575470114d078b3ca3622ae30fba6eR581 |
@@ -56,6 +56,10 @@ directory and rename it to something else (e.g. ``foo``). | |||
Root Directory | |||
~~~~~~~~~~~~~~ | |||
|
|||
.. versionadded:: 3.3 | |||
The ``getRootDir()`` method is deprecated since Symfony 3.3. Use the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not been deprecated yet, have I missed that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. versionadded:: 3.3 | ||
The ``getProjectDir()`` method was introduced in Symfony 3.3. | ||
|
||
**type**: ``string`` **default**: the directory of the project ``composer.json`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"project's"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The genitive is not common for non-living things:
We normally use the ’s with people, animals though it can also be used with places, organizations and companies (which suggest a group of people).
It is not common to use the ’s with non-living things.
This fixes #7768.