Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added concrete example document #9393

Merged
merged 13 commits into from
Apr 30, 2018
Merged

Added concrete example document #9393

merged 13 commits into from
Apr 30, 2018

Conversation

michellesanver
Copy link
Contributor

In a meeting that took place the 21st of February 2018 we defined this list as a start to a concrete example document, to specifically list out some things that are unwanted behaviour.

Copy link
Contributor

@sstok sstok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor syntax issues. Content looks good 👍

@@ -0,0 +1,16 @@
Code of Conduct: Concrete Example Document
==========================================
This is a living document that serves to give concrete examples to unwanted behaviour. These examples have all taken place somewhere in the PHP community in the past, and are clear code of conduct violations according to the Symfony code of conduct.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation lines are usually limited to 72 characters or somewhere near 👍 and headers are followed by a single empty line (sphinxdoc can be picky about this 😄 )

http://symfony.com/doc/current/contributing/documentation/standards.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed :)

Concrete Examples
-----------------
- Unwelcome comments regarding a person’s lifestyle choices and practices, including those related to food, health, parenting, drugs, and employment.
- Deliberate misgendering or use of ‘dead’ (rejected) names
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a short explanation about this? Like the one in the referenced source.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really sad to read that all this happened for real 😞. Thanks for contributing it!

Concrete Examples
-----------------
- Unwelcome comments regarding a person’s lifestyle choices and practices, including those related to food, health, parenting, drugs, and employment.
- Deliberate misgendering or use of ‘dead’ (rejected) names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deadname concept is not that well-known, so what do you think about linking it to https://en.wiktionary.org/wiki/deadname or adding a brief description like this one?

- Deliberate misgendering or use of deadnames (which are the original names given to
  transgender people before initiating their transition).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed :)

Code of Conduct: Concrete Example Document
==========================================

This is a living document that serves to give concrete examples to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to => of ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure "of" is right in this case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "of" is the correct preposition in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, of is better. Changed it. Thanks! :)

@egircys egircys mentioned this pull request Mar 5, 2018
4 tasks
Copy link
Member

@egircys egircys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be placed under contributing/code_of_conduct/concrete_example_document.rst?

@michellesanver
Copy link
Contributor Author

@egircys Of course! Didn't know quite where to place it. I moved it there now 👍

@greg0ire
Copy link
Contributor

greg0ire commented Mar 6, 2018

@michellesanver Travis says you should add that document to a toctree (it's unreachable otherwise).

@lsmith77
Copy link
Contributor

lsmith77 commented Mar 6, 2018

@javiereguiluz javiereguiluz added the diversity & inclusion Related to Symfony Diversity Initiative https://github.com/symfony/diversity label Mar 7, 2018
- Pattern of inappropriate social contact, such as requesting/assuming
inappropriate levels of intimacy with others
- Continued one-on-one communication after requests to cease
- Putting down people based on their technology choices or their work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix some minor syntatic things here:

  • Please use * as list indicator
  • Please end all entries with a semi-colon, except from the last item which should end with a final stop (.).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed :)

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great list to me. Thanks.

- Threats of violence like "The person that created this PR should be
punched in the face"
- Incitement of violence towards any individual, including encouraging a
person to commit suicide or to engage in self-harm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it makes sense to add something like "even as a joke" (or something similar)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does make sense, thanks! Added.

Egidijus Gircys and others added 2 commits April 30, 2018 19:09
This PR was submitted for the master branch but it was squashed and merged into the 2.7 branch instead (closes symfony#9394).

Discussion
----------

Adding Code of Conduct

Adding the Contributor Covenant Code of Conduct version 1.4.
Relates to symfony/diversity#1

**TODO**
- [x] Add the link to the enforcement team page
- [x] Add the link to the enforcement process
- [x] Add the link to concrete real-world examples of unwanted behavior
- [x] Change "Project maintainers" to "Enforcement team members"

Part of symfony#9340 and symfony#9393

Replaces symfony/symfony#24896

Commits
-------

02e4860 update contributor covenant link & documents fix
2de768f change project team to enforcement team
0e7b539 add link to core team
e61a403 Replace ethnicity with ethnic origin
2f8aa5d Change "race" to "ethnic origin"
1b0e633 Change "project's leadership" to "core team"
464ea45 add link to examples document
eba3ecf Adding Code of Conduct
@fabpot
Copy link
Member

fabpot commented Apr 30, 2018

Thank you very much @michellesanver for taking the time to create the document and everybody for the constructive feedback.

@fabpot fabpot changed the base branch from master to 2.7 April 30, 2018 17:13
@fabpot fabpot merged commit cccf869 into symfony:2.7 Apr 30, 2018
fabpot added a commit that referenced this pull request Apr 30, 2018
…llesanver)

This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #9393).

Discussion
----------

Added concrete example document

In a meeting that took place the 21st of February 2018 we defined this list as a start to a concrete example document, to specifically list out some things that are unwanted behaviour.

Commits
-------

cccf869 Update concrete_example_document.rst
c762418 Syntax
201738f Updated to say that some jokes are not ok
7911a86 Added concrete example document
@xabbuh xabbuh added this to the 2.7 milestone May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diversity & inclusion Related to Symfony Diversity Initiative https://github.com/symfony/diversity Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet