Change sess_time from unsigned to signed #9506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 3.3 branch. Discussion ---------- Removed some unneeded white spaces Commits ------- 0d38b1c Removed some unneeded white spaces
* 2.7: Fixed a typo in templating/debug.rst Mention the SensioGeneratorBundle in the bundles article Use stricter syntax when testing Fix default value of strict_variables minor #9042 add missing twig dump construct (hellomedia, javiereguiluz)
* 2.8: Fixed a typo in templating/debug.rst Mention the SensioGeneratorBundle in the bundles article Use stricter syntax when testing Fix default value of strict_variables minor #9042 add missing twig dump construct (hellomedia, javiereguiluz)
* 3.3: Removed some unneeded white spaces Fixed a typo in templating/debug.rst Mention the SensioGeneratorBundle in the bundles article Use stricter syntax when testing Fix default value of strict_variables minor #9042 add missing twig dump construct (hellomedia, javiereguiluz)
* 2.7: Fixed the default value for toolbar configuration Close the tag minor #9051 Update routing.rst (rickwest)
* 2.8: Fixed the default value for toolbar configuration Close the tag minor #9051 Update routing.rst (rickwest)
* 3.3: Fixed the default value for toolbar configuration Close the tag minor #9051 Update routing.rst (rickwest)
* 2.7: Use escaped backslashes Adding the missing attr option to the ChoiceType Update choice.rst Minor fixes in the bundles article
* 2.8: Use escaped backslashes Add information about default value for decoration_priority Adding the missing attr option to the ChoiceType Update choice.rst Minor fixes in the bundles article
* 3.3: Use escaped backslashes Don't mention the UserInterface type-hinting Add information about default value for decoration_priority Adding the missing attr option to the ChoiceType Update choice.rst Minor fixes in the bundles article
- note the addition of PruneableInterface - note the variouse, concrete PruneableInterface::prune() implementations in ChainAdapter, FilesystemAdapter, PdoAdapter, PhpFilesAdapter, ChainCache, FilesystemCache, PdoCache, PhpFilesCache, and TagAwareAdapter. - note the addition of CachePoolPruneCommand, invokable via cache:pool:prune. This command iterates over all services tagged cache.pool and calls the PruneableInterface::prune() method on those that implement PruneableInterface - rewording of some adapter text for clarity - additional note blocks for all caches that implement PruneableInterface - addition of prune() description and usage example on the chain adapter - addition of a tip about achieving better performance with the filesystem adapter by utilizing tmpfs or another ram disk solution - fix for an incorrect use statement in the PHP array cache adapter code example - addition of documentation page for PHP files adapter - addition of a "pruning cache items" explanation and example on the main cache pools page
…dapter|simple) prune method and prune command (robfrawley, javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [Cache] Document (filesystem|phpfiles|pdo|chain) cache (adapter|simple) prune method and prune command This PR documents the changes introduced in symfony/symfony#23451 and symfony/symfony#23603: - The addition of [`PruneableInterface`](https://github.com/symfony/cache/blob/master/PruneableInterface.php) - The variouse, concrete [`PruneableInterface::prune()`](https://github.com/symfony/cache/blob/master/PruneableInterface.php#L22) implementations in [`ChainAdapter`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Adapter/ChainAdapter.php), [`FilesystemAdapter`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Adapter/FilesystemAdapter.php), [`PdoAdapter`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Adapter/PdoAdapter.php), [`PhpFilesAdapter`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Adapter/PhpFilesAdapter.php),[ `ChainCache`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Simple/ChainCache.php), [`FilesystemCache`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Simple/FilesystemCache.php), [`PdoCache`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Simple/PdoCache.php), [`PhpFilesCache`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Simple/PhpFilesCache.php), and [`TagAwareAdapter`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php). - The addition of [`CachePoolPruneCommand`](https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Command/CachePoolPruneCommand.php), invokable via `cache:pool:prune`. This command iterates over all services tagged `cache.pool` and calls the [`PruneableInterface::prune()`](https://github.com/symfony/cache/blob/master/PruneableInterface.php#L22) method on those that implement [`PruneableInterface`](https://github.com/symfony/cache/blob/master/PruneableInterface.php) Additionally, some language changes and cleanup has been implemented for the various cache docs. Of note are the following changes: - Additional `note` blocks for all caches that implement [`PruneableInterface`](https://github.com/symfony/cache/blob/master/PruneableInterface.php) - Addition of `prune()` description and usage example on the chain adapter - Addition of a `tip` about achieving better performance with the filesystem adapter by utilizing `tmpfs` or another ram disk solution - Fix for an incorrect `use` statement in the PHP array cache adapter code example - Addition of documentation page for PHP files adapter - Addition of a "pruning cache items" explanation and example on the main cache pools page Commits ------- 54a1e62 Typo 1322ffd Typos and wrapped long lines 5bea1e6 Fixed a typo eb70a36 Wrapped long lines ea29252 document cache pruning functionality - note the addition of PruneableInterface - note the variouse, concrete PruneableInterface::prune() implementations in ChainAdapter, FilesystemAdapter, PdoAdapter, PhpFilesAdapter, ChainCache, FilesystemCache, PdoCache, PhpFilesCache, and TagAwareAdapter. - note the addition of CachePoolPruneCommand, invokable via cache:pool:prune. This command iterates over all services tagged cache.pool and calls the PruneableInterface::prune() method on those that implement PruneableInterface - rewording of some adapter text for clarity - additional note blocks for all caches that implement PruneableInterface - addition of prune() description and usage example on the chain adapter - addition of a tip about achieving better performance with the filesystem adapter by utilizing tmpfs or another ram disk solution - fix for an incorrect use statement in the PHP array cache adapter code example - addition of documentation page for PHP files adapter - addition of a "pruning cache items" explanation and example on the main cache pools page
This PR was merged into the 3.3 branch. Discussion ---------- Mentioned the TargetPathTrait utility Commits ------- 9a5f7a6 Mentioned the TargetPathTrait utility
This PR was merged into the 4.0 branch. Discussion ---------- Fixed the syntax of some internal references Travis is displaying some errors (https://travis-ci.org/symfony/symfony-docs/builds/332175270). Let's see if this fixes them. Commits ------- f333cea Fixed the syntax of some internal references
…aviereguiluz) This PR was merged into the 3.3 branch. Discussion ---------- Documented the use of PHP streams as the process input This fixes #3955 ... and goes to 3.3 branch instead of 2.7 because 3.3 is the first one that contains the needed parent section `Streaming to the Standard Input of a Process`. Commits ------- 3e3da59 Documented the use of PHP streams as the process input
* 2.7: Added a mention to the createTable() method of the session handler Remove out-of-context rewrite rule tip Mention cachetool utility to clear OPcache cache from CLI
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #9301). Discussion ---------- No more ambiguity on prod mode Because APP_ENV/SYMFONY_ENV=prod is mandatory when you want to enable the prod environment, it should be explained somewhere, explicitly. Commits ------- 97b296d Minor reword 3d7c3b3 No more ambiguity on prod mode
This PR was merged into the 3.4 branch. Discussion ---------- Made explicit testing dependencies <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- f67a47a Minor reword a99e2d5 Made explicit testing dependencies
This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Describe reliability in Lock Commits ------- b41a457 Describe reliability in Lock
This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes #9392). Discussion ---------- Use FQCN as service ID I was looking at this page in 4.0 and it seemed like a good idea to show the examples with the FQCN rather than names service IDs instead. If accepted I can also apply the same change to 4.0 branch if needed. Commits ------- 222b07f Use FQCN as service ID
…eguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Specify how provide a high availability Fixes symfony/symfony#26026 Commits ------- 2d8e18b Reword bd5a472 Specify how provide a high availability
* 2.7: Fixed a missing reference added Sam in the core team Propose identical comparison fix some security config examples [Form] Compound option explained
* 2.8: Fixed a missing reference added Sam in the core team Propose identical comparison fix some security config examples [Form] Compound option explained
|
@vyk12 thanks for this contribution! As you can see, there is some issue with the pull request and it contains hundreds of old commits instead of just your commit. Don't worry, this happens occasionally (and has happened to me lots of times!). If solving this is not simple, you can close this pull request and create a new one with this change: 1251bc2 Thanks! |
|
@javiereguiluz I'm sorry but I'm not used to make pull requests, and I therefore don't know how to solve the issue (I don't know where to begin with either of your 2 solutions.) However, I am curious about how to fix this. 1/ You say it can be solved, how? I just clicked the "edit this page" button on the Symfony documentation, and GitHub led me there. I have to admit I don't really know what I'm doing! |
|
I don't know how to solve this on the web interface of GitHub (the one you use when clicking on "Edit this page"). When using Git locally, I'd fetch the latest contents from the main repo ( In any case, this time the change you propose is very small, so you can easily create the pull request again. This is what I'd recommend you:
Hopefully the pull request will be clean this time :) |
|
Thanks a lot @javiereguiluz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. symfony/symfony#25665
This made my production system down for a couple of minutes