bug #42979 [FrameworkBundle] fix session-related BC layer triggering …

…deprecation (nicolas-grekas)

This PR was merged into the 5.3 branch.

Discussion
----------

[FrameworkBundle] fix session-related BC layer triggering deprecation

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Needed to make ##42959 green.

Commits
-------

18ab810 [FrameworkBundle] fix session-related BC layer triggering deprecation

src/Symfony/Bundle/FrameworkBundle/KernelBrowser.php

@@ -128,11 +128,14 @@ public function loginUser(object $user, string $firewallContext = 'main'): self
         $container = $this->getContainer();
         $container->get('security.untracked_token_storage')->setToken($token);
 
-        if (!$container->has('session') && !$container->has('session_factory')) {
+        if ($container->has('session.factory')) {
+            $session = $container->get('session.factory')->createSession();
+        } elseif ($container->has('session')) {
+            $session = $container->get('session');
+        } else {
             return $this;
         }
 
-        $session = $container->get($container->has('session') ? 'session' : 'session_factory');
         $session->set('_security_'.$firewallContext, serialize($token));
         $session->save();