-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Form] removed a constraint in PropertyPath as the path can definitel…
…y be an empty string for errors attached on the main form (when using a constraint defined with the 'validation_constraint' option)
- Loading branch information
Showing
2 changed files
with
1 addition
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5182a0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, the assumption taken here is wrong and I'm going to revert the commit. The property path must never accept an empty value. If an error is mapped to an empty path, no PropertyPath instance should be created.