Skip to content

Commit

Permalink
[Scheduler] Add the possibility to override the default CallbackTrigg…
Browse files Browse the repository at this point in the history
…er description
  • Loading branch information
fabpot committed Apr 24, 2023
1 parent a3988f2 commit 6c48630
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Scheduler\Tests\Trigger;

use PHPUnit\Framework\TestCase;
use Symfony\Component\Scheduler\Trigger\CallbackTrigger;

class CallbackTriggerTest extends TestCase
{
public function testToString()
{
$trigger = new CallbackTrigger(fn () => null);
$this->assertMatchesRegularExpression('/^\d{32}$/', (string) $trigger);

$trigger = new CallbackTrigger(fn () => null, '');
$this->assertSame('', (string) $trigger);

$trigger = new CallbackTrigger(fn () => null, 'foo');
$this->assertSame('foo', (string) $trigger);
}
}
6 changes: 4 additions & 2 deletions src/Symfony/Component/Scheduler/Trigger/CallbackTrigger.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,17 @@
final class CallbackTrigger implements TriggerInterface
{
private \Closure $callback;
private string $description;

public function __construct(callable $callback)
public function __construct(callable $callback, string $description = null)
{
$this->callback = $callback(...);
$this->description = $description ?? spl_object_hash($this->callback);
}

public function __toString(): string
{
return spl_object_hash($this->callback);
return $this->description;
}

public function getNextRunDate(\DateTimeImmutable $run): ?\DateTimeImmutable
Expand Down

0 comments on commit 6c48630

Please sign in to comment.