Skip to content

Commit

Permalink
minor #35948 [String] move symfony/translation-contracts to require-d…
Browse files Browse the repository at this point in the history
…ev (nicolas-grekas)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[String] move symfony/translation-contracts to require-dev

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Since it's needed only if `AsciiSlugger` is used.
Surprisingly, the code in `FrameworkExtension` deals with this as if the dep was already optional:
https://github.com/symfony/symfony/blob/210ea2202b7384ac5e5793ae64f9bfe561c857e5/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L217-L220

Commits
-------

aea80ed [String] move symfony/translation-contracts to require-dev
  • Loading branch information
fabpot committed Mar 4, 2020
2 parents 210ea22 + aea80ed commit 7c90c8b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Symfony/Component/String/composer.json
Expand Up @@ -19,12 +19,12 @@
"php": "^7.2.5",
"symfony/polyfill-intl-grapheme": "~1.0",
"symfony/polyfill-intl-normalizer": "~1.0",
"symfony/polyfill-mbstring": "~1.0",
"symfony/translation-contracts": "^1.1|^2"
"symfony/polyfill-mbstring": "~1.0"
},
"require-dev": {
"symfony/error-handler": "^4.4|^5.0",
"symfony/http-client": "^4.4|^5.0",
"symfony/translation-contracts": "^1.1|^2",
"symfony/var-exporter": "^4.4|^5.0"
},
"autoload": {
Expand Down

0 comments on commit 7c90c8b

Please sign in to comment.