-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
minor #15434 [property-access] Improvement for Accessing Reference Ch…
…ain (zerustech) This PR was merged into the 2.7 branch. Discussion ---------- [property-access] Improvement for Accessing Reference Chain Improve performance for the following scenarios: - Example 1: ```php $a = array( 'a' => array( 'b' => array( 'c' => 'old-value' ) ) ); $pa->setValue($a, '[a][b][c]', 'new-value'); // The PropertyAccessor will try to set values for // $a['a']['b']['c'], $a['a']['b'] and $a['a'], // but in fact it may terminate the loop // right after the value of $a[a][b][c] is set, // because $a, $[a], $[a][b] and $[a][b][c] // are all passed as reference - the reference chain is not broken. ``` - Example 2 ```php $b = array( 'a' => array( 'b' => array( 'c' => 'old-value' ) ) ) $a = new Foo($b); // In this example, the reference chain of $b is broken, // because it's passed to $a.value as value // But its elements are all passed as reference, // so after setting the value for $b[a][b][c], there is no need // to set value for $b[a][b] and $b[a] $pa->setValue($a, 'value[a][b][c]', 'new-value'); ``` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- e24a798 [property-access] Improvement for Accessing Reference Chain
- Loading branch information
Showing
1 changed file
with
37 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters