[WebServerBundle] fixed server:start when already running

symfony · Jan 5, 2017 · 961d1ce · 961d1ce
1 parent 126f4d9
commit 961d1ce
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerStartCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerStartCommand.php
@@ -100,6 +100,12 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         try {
             $server = new WebServer();
+            if ($server->isRunning($input->getOption('pidfile'))) {
+                $io->error(sprintf('The web server is already running (listening on http://%s).', $server->getAddress($input->getOption('pidfile'))));
+
+                return 1;
+            }
+
             $config = new WebServerConfig($documentRoot, $env, $input->getArgument('addressport'), $input->getOption('router'));
 
             if (WebServer::STARTED === $server->start($config, $input->getOption('pidfile'))) {

diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerStatusCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerStatusCommand.php
@@ -47,7 +47,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $io = new SymfonyStyle($input, $output);
         $server = new WebServer();
         if ($server->isRunning($input->getOption('pidfile'))) {
-            $io->success('Web server still listening.');
+            $io->success(sprintf('Web server still listening on http://%s', $server->getAddress($input->getOption('pidfile'))));
         } else {
             $io->warning('No web server is listening.');
         }

diff --git a/src/Symfony/Bundle/WebServerBundle/WebServer.php b/src/Symfony/Bundle/WebServerBundle/WebServer.php
@@ -109,6 +109,16 @@ public function stop($pidFile = null)
         unlink($pidFile);
     }
 
+    public function getAddress($pidFile = null)
+    {
+        $pidFile = $pidFile ?: $this->getDefaultPidFile();
+        if (!file_exists($pidFile)) {
+            return false;
+        }
+
+        return file_get_contents($pidFile);
+    }
+
     public function isRunning($pidFile = null)
     {
         $pidFile = $pidFile ?: $this->getDefaultPidFile();