Skip to content

Commit

Permalink
feature #31700 [MonologBridge] RouteProcessor class is now final to e…
Browse files Browse the repository at this point in the history
…ase the the removal of deprecated event (Simperfit)

This PR was merged into the 4.4 branch.

Discussion
----------

[MonologBridge] RouteProcessor class is now final to ease the the removal of deprecated event

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none  <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

To ease the removal of deprecated events this class has been made final as said in #31672 (comment)

Commits
-------

9646364 [MonologBridge] RouteProcessor class is now final to ease the the removal of deprecated event
  • Loading branch information
nicolas-grekas committed May 31, 2019
2 parents 8fc75e3 + 9646364 commit 9934252
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 1 deletion.
7 changes: 6 additions & 1 deletion UPGRADE-4.4.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,13 @@ DependencyInjection
factory: ['@factory_service', method]
```
MonologBridge
--------------
* The `RouteProcessor` has been marked final.

TwigBridge
----------

* Deprecated to pass `$rootDir` and `$fileLinkFormatter` as 5th and 6th argument respectively to the
`DebugCommand::__construct()` method, swap the variables position.
`DebugCommand::__construct()` method, swap the variables position.
5 changes: 5 additions & 0 deletions UPGRADE-5.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,11 @@ Monolog

* The methods `DebugProcessor::getLogs()`, `DebugProcessor::countErrors()`, `Logger::getLogs()` and `Logger::countErrors()` have a new `$request` argument.

MonologBridge
--------------

* The `RouteProcessor` class is final.

Process
-------

Expand Down
5 changes: 5 additions & 0 deletions src/Symfony/Bridge/Monolog/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
CHANGELOG
=========

4.4.0
-----

* The `RouteProcessor` class has been made final

4.3.0
-----

Expand Down
2 changes: 2 additions & 0 deletions src/Symfony/Bridge/Monolog/Processor/RouteProcessor.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
* Adds the current route information to the log entry.
*
* @author Piotr Stankowski <git@trakos.pl>
*
* @final since Symfony 4.4
*/
class RouteProcessor implements EventSubscriberInterface, ResetInterface
{
Expand Down

0 comments on commit 9934252

Please sign in to comment.