Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
…AuthenticationProvider (glutamatt) This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #11058). Discussion ---------- [Security] bug #10242 Missing checkPreAuth from RememberMeAuthenticationProvider | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10242 | License | MIT [Security] fixed missing call to UserChecker::checkPreAuth edit : after the discution with @hellomedia , i replaced postcheck with precheck glutamatt@e0730e0#commitcomment-6580764 Commits ------- a38d1cd bug #10242 Missing checkPreAuth from RememberMeAuthenticationProvider
- Loading branch information
Showing
2 changed files
with
9 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a05a95c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabpot: You merged the fix into the 2.3 branch but the problem is present in 2.4 as well. Will 2.3 be merged into 2.4 or what are your plans / thoughts here?
a05a95c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dschenk Yes, older branches are merged to newer ones on a regular basis. Note that 2.4 is not maintained anymore though. So, this patch is going to be in the next version of 2.4, but that's going to be the last one.
a05a95c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabpot: I understand, thanks for the clarification.