[Routing] removed an optimization as it does not always work as expected

symfony · Jun 17, 2011 · c536797 · c536797
1 parent 968cc75
commit c536797
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/src/Symfony/Component/Routing/Matcher/Dumper/PhpMatcherDumper.php b/src/Symfony/Component/Routing/Matcher/Dumper/PhpMatcherDumper.php
@@ -125,7 +125,6 @@ private function compileRoutes(RouteCollection $routes, $supportsRedirections, $
                 }
 
                 if ($optimizable && $prefix !== $parentPrefix) {
-                    $code[] = "            throw 0 < count(\$allow) ? new MethodNotAllowedException(array_unique(\$allow)) : new ResourceNotFoundException();";
                     $code[] = "        }\n";
                 }
             } else {

diff --git a/tests/Symfony/Tests/Component/Routing/Fixtures/dumper/url_matcher1.php b/tests/Symfony/Tests/Component/Routing/Fixtures/dumper/url_matcher1.php
@@ -125,7 +125,6 @@ public function match($pathinfo)
                     return $matches;
                 }
 
-                throw 0 < count($allow) ? new MethodNotAllowedException(array_unique($allow)) : new ResourceNotFoundException();
             }
 
             // ababa
@@ -139,7 +138,6 @@ public function match($pathinfo)
                 return $matches;
             }
 
-            throw 0 < count($allow) ? new MethodNotAllowedException(array_unique($allow)) : new ResourceNotFoundException();
         }
 
         // foo

diff --git a/tests/Symfony/Tests/Component/Routing/Fixtures/dumper/url_matcher2.php b/tests/Symfony/Tests/Component/Routing/Fixtures/dumper/url_matcher2.php
@@ -137,7 +137,6 @@ public function match($pathinfo)
                     return $matches;
                 }
 
-                throw 0 < count($allow) ? new MethodNotAllowedException(array_unique($allow)) : new ResourceNotFoundException();
             }
 
             // ababa
@@ -151,7 +150,6 @@ public function match($pathinfo)
                 return $matches;
             }
 
-            throw 0 < count($allow) ? new MethodNotAllowedException(array_unique($allow)) : new ResourceNotFoundException();
         }
 
         // foo