[Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator #10772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return parent::getChildren(); | ||
| $children = parent::getChildren(); | ||
|
|
||
| if ($children instanceof RecursiveDirectoryIterator) { |
There was a problem hiding this comment.
maybe instanceof self which is more obvious
|
Can you not add a test just as #10747 demonstrates? |
|
How would I make a cleanup after test if I revoked permissions to myself? |
|
Good question ;) |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Apr 24, 2014
…irectoryIterator (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10747 | License | MIT | Doc PR | - `\RecursiveDirectoryIterator::getChildren()` creates an instance of the current (overloaded) class with default constructor arguments. Therefore the `ignoreUnreadableDirs` is not passed to the child directories as @marcj suggested in #10747. My fix relies on PHP's ability to modify private properties in objects of the same class. My reasoning behind choosing this approach, instead of using a setter, is that it's an internal detail which doesn't need to be part of a public interface. Unfortunately, I can't really cover this case by tests. Commits ------- 1346641 [Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator.
|
Maybe someone should add an "incomplete" note to the according test so that we don't forget there is something missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\RecursiveDirectoryIterator::getChildren()creates an instance of the current (overloaded) class with default constructor arguments. Therefore theignoreUnreadableDirsis not passed to the child directories as @marcj suggested in #10747.My fix relies on PHP's ability to modify private properties in objects of the same class. My reasoning behind choosing this approach, instead of using a setter, is that it's an internal detail which doesn't need to be part of a public interface.
Unfortunately, I can't really cover this case by tests.